Remove IfW data from AD15 inputs #1882
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The
The differences are very small. For example, for the B2RootMzr: Zoomed in: These differences completely vanish if a correction step is used in both the reference and the test case. |
andrew-platt
force-pushed
the
f/AD15_IfW_dataAccess
branch
from
6c699d3
to
511f328
Compare
andrew-platt
force-pushed
the
f/AD15_IfW_dataAccess
branch
from
2feff68
to
dd504f9
Compare
- Add extrap-interp routine in registry for AD_RotInflowType (temporary for testing) - Add RotInflow type to AD, and add this into misc vars. This, with the above, should produce exactly the same results as before. This is almost working locally, but fails on one test. Hoping this is just numerics that work on GH (going to test).
andrew-platt
force-pushed
the
f/AD15_IfW_dataAccess
branch
from
74c3514
to
cc66e08
Compare
…AD15_IfW_dataAccess
andrew-platt
force-pushed
the
f/AD15_IfW_dataAccess
branch
from
bddcdfb
to
5751e09
Compare
This was referenced Apr 30, 2024
deslaughter
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
This is the first of 3 PR's to fix the linearization in AD15 after converting the IfW data handling to pointers. The three PRs are:
PR 1
The IfW data is removed from the AD15 inputs. To match prior regression tests, the registry is temporarily modified to generate an extrap/interp routine for the new data structure
AD_InflowType. This allows extrapolating the wind data for BEMT which gives a an exact match to the previous behavior.Note: the input positions for the blade motion mesh stored in
u(1)for theT + dttime step are used to calculate the wind. This yields very slightly different for wind based on extrapolated positions vs. extrapolated wind based on previous time steps. This causes the5MW_Land_BD_DLL_WTurbtest case to fail, but the test will pass with a correction step in both the reference and the test case. See below.Related issue, if one exists
Impacted areas of the software
Internal data management of AD15 only. No other modules affected.
Additional supporting information
This series of PRs will allow us to merge the
dev-unstable-pointersbranch intodevTest results, if applicable
All regression tests match exactly with the exception of
5MW_Land_BD_DLL_WTurbtest case. This case has very small differences with the previous results (samples plotted below). However, this is due to calculating the wind atT + dtusing the extrapolated positions, rather than extrapolating the wind from previous time steps. Running this test case with on correction step with both this branch and thedev-unstable-pointersbranch yields identical results.