Remove default include paths #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpikes
force-pushed
the
fix/remove-default-include-paths
branch
from
bc3733b
to
a8af0b9
Compare
carpikes
changed the title
carpikes
force-pushed
the
fix/remove-default-include-paths
branch
from
8ae201f
to
cb94b78
Compare
carpikes
force-pushed
the
fix/remove-default-include-paths
branch
from
c2321f9
to
d33c49a
Compare
n1zzo
force-pushed
the
master
branch
5 times, most recently
from
2d75e11
to
04d6d01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the ambiguous include paths.
Now the only two openrtx include paths are
openrtx/andplatform/.Also, I used the following convention for
#include <>VS#include "":#include <..>indicates an include of system libraries, miosix libraries, external libraries#include ".."indicates an include of openrtx libraries, local (current directory) libraries.This means that if we want to include
openrtx/core/utils.hwe should write#include "core/utils.h"instead of just#include utils.h. Also, this PR applies clang-format to the include list of all changed files.Let me know what do you think.