Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Properties with Map<String, String> in Exporters interfaces #6460

Open
wants to merge 7 commits into
base: 4.0
Choose a base branch
from

Conversation

karindev
Copy link

Fixes #6419

This makes changes to the 4.0 branch since the interface is already modified due to other changes.

Changes proposed in this pull request:

  • Uses of Properties are replaced with Map<String, String> in the export() method of Exporters interfaces
  • The classes implementing the interfaces are updated to match
  • Methods exportRows() and countColumnRows() CustomizableTabularExporterUtilities are also changed to use Map<String, String> to accommodate the change
  • Unit tests are updated to match all changed code and mocking is removed where unnecessary

@wetneb
Copy link
Sponsor Member

wetneb commented Mar 28, 2024

Thanks a lot for this!
I think I intuitively agree with the idea that it's worth doing this sort of change on the occasion of a larger change of interface, so adding it on top of the data model changes feels right in that sense. On the other hand there is also a case for keeping breaking changes as atomic as possible and giving people the opportunity to migrate gradually. We are currently discussing how to schedule such changes on the forum:
https://forum.openrefine.org/t/scheduling-breaking-changes-we-have-on-our-radar/1410/4

In the light of this discussion, I would keep this PR open (probably for a long time) until we have some clarity on how we proceed.
From my side, I would like to express my support to your approach and my gratitude for your work - even if it might not be reflected in the formal status of this PR as soon as I would wish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants