New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Byte Order Mark (BOM) correctly for CSVs. Fixes #6527 #6528

Closed

tfmorris wants to merge 1 commit into OpenRefine:master from tfmorris:6527-csv-bom

Member

tfmorris commented Apr 11, 2024

DRAFT - still needs test updates

Fixes #6527

Changes proposed in this pull request:

Create utility method to handle creating an InputStreamReader with a character encoding which is null, our special BOM encoding, or an actual Java character encoding to centralize handling of this
Replace all conditional code with calls to the new utility


          Handle Byte Order Mark (BOM) correctly for CSVs. Fixes OpenRefine#6527

c801e46

github-actions bot added Type: Bug Status: Pending Review import labels

Member Author

tfmorris commented May 10, 2024

Closing this in favor of #6596. The piece that replaces this is in commit 076f836

tfmorris closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment