Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve pagination after actions which trigger a grid update #6546

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Preserve pagination after actions which trigger a grid update #6546

wants to merge 3 commits into from

Commits on May 16, 2024

  1. Preserve pagination after actions which trigger an update of the grid (… 

    …OpenRefine#5411)

* Adapt the GridState interface to separate sorting and pagination.

This adds `getRowsBefore` methods, counterpart to the existing pagination
methods, so that we can do efficient and correct pagination, solving #33 and OpenRefine#570

* Revert "(I OpenRefine#2638) Feature to Goto a page directly (OpenRefine#2639)"

Go back to simply displaying a range of row numbers, because
that will enable a solution for #33, OpenRefine#570 and OpenRefine#572.
This reverts commit d7aaac2.

* Do not move back to the first page when applying an action which refreshes the grid.

Instead, the current page is refreshed.
This closes #33, closes OpenRefine#570, closes OpenRefine#572.

* Specify which actions preserve row and record ids

This lets us preserve pagination only when it is guaranteed to show the same
part of the data after the operation.

* Make paging user-editable like before

* Adapt cypress tests
    @wetneb
    wetneb committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7cca194 View commit details
    Browse the repository at this point in the history

  2. Preserve pagination also when discarding recon matches

    @wetneb
    wetneb committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4dc666e View commit details
    Browse the repository at this point in the history

  3. Change visibility of internalVisit 

    Co-authored-by: Tom Morris <tfmorris@gmail.com>
    @wetneb @tfmorris
    wetneb and tfmorris committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7a96afc View commit details
    Browse the repository at this point in the history