Feature: [NewGRF] Allow fixed layout up to 256 tiles per NewGRF rail station. #12554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AYOUT. These callbacks both select rail station tile layouts, the difference is one happens when drawing, the other happens when building. Change the names to make this clearer.
Using std::span provides both the start and end of the list, which allows validating that the requested layout is in range.
|
My understanding of station tiles was, they are mostly used to control |
|
The only reason for that's what "they are mostly used to control" is because with only 8 layouts there isn't flexibility to do much else. Added new property 1E to define per-tile flags as a list. |
…station. Allow using up to 256 tile layouts in property 0E or callback 24, which defines the layout to be saved into the map. This was originally limited to 8, because station graphics above 8 referred to other station types but that was changed in 2007. 1) More efficient than using callback 14, as that needs to be checked every time a station tile is rendered. 2) The layout does not get changed when the station is changed (this may or may not be desirable!) Using more than 256 layouts still requires callback 14.
PeterN
changed the title
Properties 11, 14 and 15 to set pylons/nowires/blocked intrinsically only support 8 station tiles. Add new property to define all three flags for each station tile layout.
|
An additional (but out of scope) idea that may be desirable is to automatically "rebuild" the layout if parts are over-built or removed, so it could behave as a semi-dynamic layout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Station layouts may contain more than 8 different tile types, but due to hysterical reasons, only 8 tiles can be used and stored in the map on build.
Callback 24 exists which allows to choose the fixed layout dynamically but this is still limited to 8.
Using more than this requires using callback 14, which allows more (more than 256 even) but also requires complex calculations for each station tile to be drawn.
The technical limit that originally prevented using more than 8 tile layouts on the map was removed in 2007, in commit 3dd6362.
Description
Allow using up to 256 tile layouts in property 0E or callback 24, which defines the layout to be saved into the map.
This was originally limited to 8, because station graphics above 8 referred to other station types but that was changed in 2007.
Using more than 256 layouts still requires callback 14.
Limitations
Not actually tested as this requires skill at creating NewGRF stations...
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.