Fix #12497: [NewGRF] Increase vehicle motion counter for all parts. #12561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
#12229 stopped updating motion_counter for non-engine parts of trains, and in doing so accidentally followed the spec for NewGRF var 46, which breaks NewGRFs that used to accidentally work, but by the spec should not.
Fixes #12497.
Description
Some NewGRFs relied on the incorrectly motion counter that was 'fixed' in #12229, so always update v->motion_counter for all vehicle parts.
Always updating means that motion counters are still per-vehicle.
Limitations
Update motion counter for all vehicles might have a minor performance impact.
This still goes "against" the spec, but the spec could be updated to define this behaviour.
Alternatively we could leave #12497 option and let authors fix their sets.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.