Add: [NewGRF] Extended custom waypoint classes. #12653
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Authors have asked for more custom waypoint classes, as lumping all waypoints into just one class gives a very big list.
The simplest way to achieve this, instead of adding more properties, is to allow more classes to be treated as waypoints.
Description
With this PR, station class labels with the first byte set to 0xFF will be treated in the same way as the 'WAYP' class. Also applies to road stop waypoints, although those are not supported yet.
This allows waypoints to be split into categories just like stations, instead of all being lumped together.
Modified version of UK Waypoints for testing:
UK_Waypoints-1.zip
Limitations
My review of all the custom station and roadstop NewGRF files I have available showed that they all use only ASCII characters for the class label. Therefore, the 0xFF marker was chosen because it minimises the chance of conflicts with existing NewGRFs... but it's not impossible.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.