Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Use reusable temporary buffer in Win32FontCache. #12666

Merged
merged 1 commit into from May 17, 2024

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented May 12, 2024

Motivation / Problem

Manual new[]/delete[] in Win32FontCache.

Description

Use ReusableBuffer instead. This removes the manual management (or at least moves it somewhere else...) and avoids allocating and deleting a temporary buffer for every glyph that is rendered into a sprite.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

This avoids allocating and deleting a temporary buffer for every glyph that is rendered into a sprite.
Copy link
Contributor

@rubidium42 rubidium42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see anything that could go awry.

@PeterN PeterN merged commit c854815 into OpenTTD:master May 17, 2024
14 checks passed
@PeterN PeterN deleted the win32-reusable branch May 17, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants