Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12411: [Admin] Send Network Welcome Packet to admin port after game creation completed #12672

Merged
merged 1 commit into from May 14, 2024

Conversation

MuxyDuGoulp
Copy link
Contributor

Motivation / Problem

ADMIN_PACKET_SERVER_WELCOME is sent too early when a newgame is issued with an external bot already connected through AdminPort.

See #12411.

Description

Move the sending of the packet to a better appropriate place when the game creation is over : NetworkOnGameStart

Closes #12411.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested') : No
  • This PR touches english.txt or translations? Check the guidelines : No
  • This PR affects the save game format? (label 'savegame upgrade') : No
  • This PR affects the GS/AI API? (label 'needs review: Script API') : No
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF') : No

…after game creation completed

WelcomeAll moved into NetworkOnGameStart

Signed-off-by: Muxy <muxy@goulp.net>
@2TallTyler
Copy link
Member

Git history looks good now. 😃 Now just leave the Update branch button alone, it's not necessary to keep the PR up-to-date with the base branch as long as the merge rules below say Merging can be performed automatically with 1 approving review.

I am not familiar with AdminPort so I won't review this PR, but I'm sure someone else will take a look soon.

@rubidium42 rubidium42 changed the title Fix: [Admin] #12411 Send Network Welcome Packet to admin port after game creation completed Fix #12411: [Admin] Send Network Welcome Packet to admin port after game creation completed May 13, 2024
@rubidium42 rubidium42 added the backport requested This PR should be backport to current release (RC / stable) label May 13, 2024
@rubidium42 rubidium42 merged commit 486af1a into OpenTTD:master May 14, 2024
15 checks passed
@MuxyDuGoulp MuxyDuGoulp deleted the welcome-packet branch May 14, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport requested This PR should be backport to current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Admin packet SERVER_WELCOME can send UINT32_MAX as seed
3 participants