Skip to content

Commit

Permalink
change targets to compares
Browse files Browse the repository at this point in the history
  • Loading branch information
gschoeni committed Mar 6, 2024
1 parent 97ca3ad commit 8febd30
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions oxen/python/oxen/diff/diff.py
Expand Up @@ -55,7 +55,7 @@ def diff(
revision_right: Optional[str] = None,
output: Optional[os.PathLike] = None,
keys: list[str] = [],
targets: list[str] = [],
compares: list[str] = [],
):
"""
Compares data from two paths and returns a diff respecting the type of data.
Expand All @@ -82,12 +82,12 @@ def diff(
Only for tabular diffs. The keys to compare on.
This is used to join the two data frames.
Keys will be combined and hashed to create a identifier for each row.
targets: `list[str]`
Only for tabular diffs. The targets to compare on.
compares: `list[str]`
Only for tabular diffs. The compares to compare on.
This is used to compare the values of the two data frames.
"""
result = py_diff.diff_paths(
path, keys, targets, to, repo_dir, revision_left, revision_right
path, keys, compares, to, repo_dir, revision_left, revision_right
)
if output:
df_utils.save(result, output)
Expand Down
4 changes: 2 additions & 2 deletions oxen/src/diff.rs
Expand Up @@ -17,7 +17,7 @@ pub use py_text_diff::PyTextDiff;
pub fn diff_paths(
path_1: PathBuf,
keys: Vec<String>,
targets: Vec<String>,
compares: Vec<String>,
path_2: Option<PathBuf>,
repo_dir: Option<PathBuf>,
revision_1: Option<String>,
Expand All @@ -27,7 +27,7 @@ pub fn diff_paths(
path_1,
path_2,
keys,
targets,
compares,
repo_dir,
revision_1,
revision_2
Expand Down

0 comments on commit 8febd30

Please sign in to comment.