new filter : calculate 2d/3d relative distance and height to target pointcloud #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellgithub
approved these changes
Nov 30, 2023
| { | ||
| PointLayoutPtr layout(table.layout()); | ||
|
|
||
| if (layout->findDim("X") == Dimension::Id::Unknown || |
There was a problem hiding this comment.
This entire function is unnecessary. X, Y and Z are guaranteed to exist.
| else | ||
| { | ||
|
|
||
| KD3Index &kd_fixed3D = this->m_target->build3dIndex(); |
There was a problem hiding this comment.
I don't think you want to build both indices.
abellgithub
reviewed
Nov 30, 2023
|
I don't understand what this is supposed to do. How is it different (besides being way less sophisticated) than |
|
This will need some updates soon if it is to make the upcoming PDAL 2.7.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The red point is the reference point cloud (the ins trajectory point), and the other is the point cloud rendered according to the relative elevation.