Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 32-bit Problem in PasswordEncoder #2551

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fix 32-bit Problem in PasswordEncoder #2551

merged 2 commits into from
Jan 23, 2024

Conversation

oleibman
Copy link
Contributor

@oleibman oleibman commented Jan 15, 2024 •
edited by Progi1984

Description

Password encoder is not 32-bit safe.

Fixes #2550

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

coveralls commented Jan 15, 2024 •
edited

Coverage Status

coverage: 97.217%. remained the same
when pulling ab7a3ae on oleibman:enc32
into 2f4da6e on PHPOffice:master.

Progi1984
Progi1984 reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleibman Approved

Could you update the changelog ?

@oleibman
Copy link
Contributor Author

@Progi1984 Change log is updated.

@Progi1984 Progi1984 added this to the 2.0.0 milestone Jan 23, 2024
@Progi1984 Progi1984 merged commit 8b891bb into PHPOffice:master Jan 23, 2024
13 checks passed
@Progi1984 Progi1984 deleted the enc32 branch May 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

32-bit Error With PasswordEncoder
3 participants
@oleibman @coveralls @Progi1984