Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Text Alignment in Xlsx Comment #4006

Merged
merged 2 commits into from
May 5, 2024
Merged

Commits on May 1, 2024

  1. RTL Text Alignment in Xlsx Comment

    Fix PHPOffice#4004. RTL text can be included in a comment, and will display correctly, but the comment as a whole will be left-aligned. There already exists an `alignment` property for Comment, but it is unused. This PR will allow that property to be set, and to be read from and written to an Xlsx spreadsheet when possible.
    
    The Xml tags that govern this property are found, unusually, in a drawing Vml file. The important property is `x:TextHAlign`, which can be set to Left, Right, Center, Justified, or Distributed. There are other tags which seemed like they were relevant to this problem, but I don't think they actually matter:
    ```xml
      <v:textbox style='mso-direction-alt:auto'>
       <div style='text-align:right;direction:rtl'></div>
      </v:textbox>
    ```
    oleibman committed May 1, 2024
    Configuration menu
    Copy the full SHA
    455f112 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Update CHANGELOG.md

    oleibman committed May 5, 2024
    Configuration menu
    Copy the full SHA
    5d1d867 View commit details
    Browse the repository at this point in the history