[Trainer] remove redundant memory metrics and set enable as default #8374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ZHUI
reviewed
May 7, 2024
paddlenlp/trainer/trainer.py
Outdated
| logs["current_memory_allocated"] = current_memory_allocated / divisor | ||
| logs["current_memory_reserved"] = current_memory_reserved / divisor | ||
| logs["max_memory_allocated"] = max_memory_allocated / divisor | ||
| logs["max_memory_reserved"] = max_memory_reserved / divisor |
There was a problem hiding this comment.
PaddleNLP/scripts/distribute/ci_case_dy.sh
Line 454 in 09a0ce7
这处也对应改了吧，gpu_max_memory_reserved -> max_memory_reserved
paddlenlp/trainer/trainer.py
Outdated
| max_memory_reserved = core.device_memory_stat_peak_value("Reserved", device_id) | ||
| logs["current_memory_allocated"] = current_memory_allocated / divisor | ||
| logs["current_memory_reserved"] = current_memory_reserved / divisor | ||
| logs["max_memory_allocated"] = max_memory_allocated / divisor |
There was a problem hiding this comment.
Suggested change
| logs["max_memory_allocated"] = max_memory_allocated / divisor | |
| logs["max_memory_allocated"] = max_memory_allocated >> 20 |
这个之前是MB单位，建议不要改变了，保持原来写法。用除法的话，是浮点数，还有小数位的问题，建议直接位运算，MB为单位
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8374 +/- ##
===========================================
+ Coverage 55.36% 55.41% +0.04%
===========================================
Files 614 615 +1
Lines 96016 96241 +225
===========================================
+ Hits 53164 53335 +171
- Misses 42852 42906 +54 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
May 7, 2024
paddlenlp/trainer/training_args.py
Outdated
| @@ -738,7 +738,7 @@ class TrainingArguments: | |||
| metadata={"help": "The path to a folder with a valid checkpoint for your model."}, | |||
| ) | |||
| skip_memory_metrics: bool = field( | |||
| default=True, metadata={"help": "Whether or not to skip adding of memory profiler reports to metrics."} | |||
| default=False, metadata={"help": "Whether or not to skip adding of memory profiler reports to metrics."} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
remove redundant memory metrics and enable memory metrics print as default