【Hackathon No.17】为 Paddle 新增 sgn #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
好的 |
|
@luotao1 已更新 |
luotao1
reviewed
Jul 8, 2022
|
已按建议更新，但是在验收部分我参考其他已通过的rfc如： |
luotao1
reviewed
Jul 11, 2022
| @@ -74,10 +78,31 @@ inline c10::complex<T> sgn_impl (c10::complex<T> z) { | |||
| } | |||
|
|
|||
| ``` | |||
|
|
|||
| github链接为：https://github.com/pytorch/pytorch/blob/d7fc864f0da461512fb7b972f04e24e296bd266d/aten/src/ATen/native/cpu/zmath.h | |||
| 156-163 | |||
There was a problem hiding this comment.
| dtype=x.dtype), | ||
| name=name) | ||
| return gen_math_ops.sign(x, name=name) | ||
| ``` |
| 如果复数为0，则直接返回0；否则，返回该复数除以它的绝对值的值 | ||
| 对于非复数直接返回其符号 | ||
| 使用is_complex判断输入是否为复数、若为实数则使用sign进行运算；若为复数则使用as_real将其转化为实数tensor，将其中的非零部分除以它自己的绝对值 | ||
| ，最后在使用as_complex将其转换回复数返回。 |
|
|
||
| # 六、测试和验收的考量 | ||
|
|
||
| 测试考虑的case如下： | ||
|
|
||
| - 数值正确性 | ||
| - 反向 | ||
| - 异常测试：由于使用了已有API：sign 该API不支持整型运算，仅支持float16， float32 或 float64，所以需要做数据类型的异常测试 | ||
| - 异常测试：由于使用了已有API：sign，该API不支持整型运算，仅支持float16， float32 或 float64，所以需要做数据类型的异常测试 |
There was a problem hiding this comment.
根据您给的建议进行了修改，但是由于目前并未进行具体的代码开发，所以不知道调用的API是否覆盖静态图和GPU测试场景。这部分是开发阶段的工作，可以在后续开发时根据代码修改RFC具体内容。
There was a problem hiding this comment.
由于目前并未进行具体的代码开发，所以不知道调用的API是否覆盖静态图和GPU测试场景
虽然没有进行开发，但设计文档中应该是要能预判的：
- 业内方案里，并没有特殊说明覆盖不了静态图和GPU场景。
- 这是用组合API形式实现的，单API都能覆盖静态图和GPU测试场景，因此组合的应该也可以。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rfc of paddle.sgn