Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsl.providers.cluster_provider _write_submit_script should return nothing, rather than constant True #3234

Closed
benclifford opened this issue Mar 11, 2024 · 6 comments · Fixed by #3238 · May be fixed by #3240
Closed

parsl.providers.cluster_provider _write_submit_script should return nothing, rather than constant True #3234

benclifford opened this issue Mar 11, 2024 · 6 comments · Fixed by #3238 · May be fixed by #3240
Labels
bug outreachy Good initial contributions for Outreachy applicants

Comments

@benclifford
Copy link
Collaborator

Describe the bug

_write_submit_script in parsl.providers.cluster_provider indicates failure by raising an exception, and so should not be returning a True (or False) value. Instead it should return None by either return on its own, or falling off the end of the method without a return statement.

To tidy this up, change that return handling. Edit the docstring to match.
@benclifford benclifford added bug outreachy Good initial contributions for Outreachy applicants labels Mar 11, 2024
@MundiaNderi
Copy link

@benclifford please assign me this issue. I'd very much like to work on it.

@benclifford
Copy link
Collaborator Author

ok, go ahead @MundiaNderi

This was referenced Mar 11, 2024
Closed
Merged
@jessielin34
Copy link
Contributor

@benclifford I've opened a PR for this issue, please review, thank you!

@mirembe-mariam mirembe-mariam mentioned this issue Mar 12, 2024
Open
@mirembe-mariam
Copy link

Hello @benclifford . Kindly review my PR about this issue

@MundiaNderi MundiaNderi mentioned this issue Mar 12, 2024
Open
@MundiaNderi
Copy link

Thank you @benclifford here is my PR on a separate branch from the rest of my work : #3240

@SobiaAman SobiaAman mentioned this issue Mar 13, 2024
Open
@SobiaAman
Copy link
Contributor

Hi @benclifford please check my PR #3248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug outreachy Good initial contributions for Outreachy applicants
Projects
None yet
Milestone
No milestone
5 participants
@benclifford @jessielin34 @MundiaNderi @mirembe-mariam @SobiaAman