Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providers none #3248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Providers none #3248

wants to merge 2 commits into from

Conversation

SobiaAman
Copy link
Contributor

Description

The _write_submit_script method currently indicates failure by raising an exception. Despite raising an exception to indicate failure, the _write_submit_script method returns a boolean value (True or False). Changes are made so that _write_submit_script method to return None instead of True or False.

Changed Behaviour

It should return None or raise an exception.

Fixes

Fixes # 3234

Type of change

Choose which options apply, and delete the ones which do not apply.

  • Bug fix

@yadudoc
Copy link
Member

yadudoc commented Mar 18, 2024

Hi @SobiaAman, it looks like this PR includes many files that were added unintentionally. If you take a look at this link -> https://github.com/Parsl/parsl/pull/3248/files you can see the files. I would recommend closing this PR and opening another with just the right changes. The task involved should only require the changes you've made to the cluster_provider -> https://github.com/Parsl/parsl/pull/3248/files#diff-e9a948ba158ffe88770badeb650cb4dcfe6ffe78bc5d35409e5b8be0679c685c .

@SobiaAman
Copy link
Contributor Author

Yeah @yadudoc, I have noticed it before pulling the request but i didn't changed anything other than in cluster_provide file, although i pulled the latest parsl code before making tha changes in cluster_provide file but i'm confused why it shows changes in all these files :/. Do you have any idea? So that i make an eye on it in future. Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants