Remove join from python_app decorator, and reimplement join_app #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The join parameter should never be set by a user, and gives bad error messages if it is set - see issue #2147. The parameter was only there so that the join_app decorator could be implemented in terms of the python_app decorator. This PR changes how that implementation works so that this misbehaviour is not exposed to end users. Fixes issue #2147
benclifford
force-pushed
the
benc-joinapp-issue-2147
branch
from
7db3d9b
to
7c467b5
Compare
benclifford
added a commit
that referenced
this pull request
Aug 11, 2023
PR #2621 didn't remove the user facing join parameter it was intended to, instead just ignoring it. That PR #2621 also added a new executors parameter to the join_app decorator, which is then ignored (as it should be - because join_apps should be forced to run in the _parsl_internal executor). This PR removes that spurious parameter. This will be a breaking change for anyone explicitly specifying the _parsl_internal decorator to join_app, or for anyone explicitly specifying join=False to python_app. (Other uses of those parameters are already broken because those parameters are ignored, and they will now be broken in different ways)
khk-globus
pushed a commit
that referenced
this pull request
Aug 11, 2023
PR #2621 didn't remove the user facing join parameter it was intended to, instead just ignoring it. That PR #2621 also added a new executors parameter to the join_app decorator, which is then ignored (as it should be - because join_apps should be forced to run in the _parsl_internal executor). This PR removes that spurious parameter. This will be a breaking change for anyone explicitly specifying the _parsl_internal decorator to join_app, or for anyone explicitly specifying join=False to python_app. (Other uses of those parameters are already broken because those parameters are ignored, and they will now be broken in different ways)
khk-globus
pushed a commit
that referenced
this pull request
Aug 11, 2023
PR #2621 didn't remove the user facing join parameter it was intended to, instead just ignoring it. That PR #2621 also added a new executors parameter to the join_app decorator, which is then ignored (as it should be - because join_apps should be forced to run in the _parsl_internal executor). This PR removes that spurious parameter. This will be a breaking change for anyone explicitly specifying the _parsl_internal decorator to join_app, or for anyone explicitly specifying join=False to python_app. (Other uses of those parameters are already broken because those parameters are ignored, and they will now be broken in different ways)
khk-globus
pushed a commit
that referenced
this pull request
Aug 11, 2023
PR #2621 didn't remove the user facing join parameter it was intended to, instead just ignoring it. That PR #2621 also added a new executors parameter to the join_app decorator, which is then ignored (as it should be - because join_apps should be forced to run in the _parsl_internal executor). This PR removes that spurious parameter. This will be a breaking change for anyone explicitly specifying the _parsl_internal decorator to join_app, or for anyone explicitly specifying join=False to python_app. (Other uses of those parameters are already broken because those parameters are ignored, and they will now be broken in different ways)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The join parameter should never be set by a user, and gives bad error messages if it is set - see issue #2147.
The parameter was only there so that the join_app decorator could be implemented in terms of the python_app decorator. This PR changes how that implementation works so that this misbehaviour is not exposed to end users.
Fixes issue #2147
Type of change