Use UUIDs for filesystem monitoring radio message identifiers #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous identifier system did not guarantee sufficient uniqueness: specifically, the use of id() to get an object identifier within a process does not return distinct values for distinct objects if those objects have non-overlapping lifetimes. This lack of uniqueness is not a problem in main current use of the filesystem radio, in Work Queue, where each task also runs inside a new proces, so os.getpid() was also providing additional uniqueness; but in under-development work to use Work Queue coprocesses, that is no longer the case. Rather than make further effort to generate unique IDs by adding more filename components, this PR uses the uuid library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous identifier system did not guarantee sufficient uniqueness: specifically, the use of id() to get an object identifier within a process does not return distinct values for distinct objects if those objects have non-overlapping lifetimes.
This lack of uniqueness is not a problem in main current use of the filesystem radio, in Work Queue, where each task also runs inside a new proces, so os.getpid() was also providing additional uniqueness; but in under-development work to use Work Queue coprocesses, that is no longer the case.
Rather than make further effort to generate unique IDs by adding more filename components, this PR uses the uuid library.
Type of change