Make Work Queue executor source code more explicit about task types #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three different entities with the word "task" used to describe them: parsl tasks, tasks that go in this executor's self.tasks dictionary, and Work Queue tasks. The executor code refers to two of them, and this PR attempts to be explicit in every log line, and in some variable names, about which kind of task is being referred to. self.tasks dictionary tasks are referred to as "executor tasks". Work Queue tasks are referred to as Work Queue tasks. This is part of an attempt to make log files easier to understand in the presence of many kinds of task.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three different entities with the word "task" used to describe them: parsl tasks, tasks that go in this executor's self.tasks dictionary, and Work Queue tasks.
The executor code refers to two of them, and this PR attempts to be explicit in every log line, and in some variable names, about which kind of task is being referred to.
self.tasks dictionary tasks are referred to as "executor tasks".
Work Queue tasks are referred to as Work Queue tasks.
This is part of an attempt to make log files easier to understand in the presence of many kinds of task.
Type of change