fix: launch_cmd not set when provided to FluxExecutor #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like an issue with pytest versioning: ImportError: cannot import name 'Config' from 'pytest' (/opt/hostedtoolcache/Python/3.10.10/x64/lib/python3.10/site-packages/pytest/__init__.py)
make: *** [Makefile:53: local_thread_test] Error 1
Error: Process completed with exit code 2.I'll await further instruction, since this is out of scope for my PR. Gnite! |
|
Yeah there's a separate PR open to fix that, which should get merged in the next few days |
jameshcorbett
approved these changes
Mar 20, 2023
|
Thanks @jameshcorbett ! |
Problem: Currently, the launch_cmd is not set if provided to the FluxExecutor directly. Many jobs are likely to start already with access to a flux instance, in which case the launch command should use flux submit instead of flux start. Solution: Ensure the launch_cmd is set. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
fix/flux-executor-launch-cmd
branch
from
c8d418c
to
8d1f09c
Compare
|
All set for both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Currently, the launch_cmd is not set if provided to the FluxExecutor directly. Many jobs are likely to start already with access to a flux instance, in which case the launch command should use flux submit instead of flux start.
Solution: Ensure the launch_cmd is set.
Description
Please include a summary of the change and (optionally) which issue is fixed. Please also include
relevant motivation and context.
Fixes #2633
Type of change
Choose which options apply, and delete the ones which do not apply.