Clearing the active DFK on cleaning #3271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ended up doing this slightly differently, in PR #3444, and in that PR I also cleaned up a lot of tests: even though they were not failing in this PR, there would now be a lot of unnecessary/redundant clear calls happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently now, on cleaning the Active DFK ( dfk.cleanup ), It releases all the resources and cleans the DFK, but it doesnt remove the reference of the cleaned dfk from the KernelLoader, It makes the user to run .clear() one more time to remove the reference of the DFK, and there are no things can be done with cleaned up dfk , even cant load a new config, So its better to clear the reference as well at cleanup, so that user can directly load another config to work on
Changed Behaviour
After this pr, at cleanup of dfk , reference of the cleaned dfk will be removed
Fixes
Fixes #3263
Type of change