Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.close() interchange process to release more fds #3399

Merged
merged 2 commits into from Apr 26, 2024

Commits on Apr 25, 2024

  1. .close() interchange process to release more fds

    This releases two fds in the workflow process used to communicate with
    the interchange process, and is part of work to release more resources
    explicitly at shutdown rather than leaving them until process end.
    
    One test was making an out-of-API shutdown of HTEX on the basis that
    the DFK would not shutdown this executor when a bad state was set. That
    used to be true, but PR 2855, which re-arranged some shutdown behaviour,
    (accidentally?) changed shutdown to always happen. That is, I think,
    the right shutdown behaviour: if an executor wants to suppress parts of
    its own shutdown based on internal state, that's the business of the
    executor, not the DFK.
    
    This PR removes that out-of-API shutdown.
    benclifford committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    26a29da View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    d1b3834 View commit details
    Browse the repository at this point in the history