Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework description of --config local tests #3402

Merged
merged 2 commits into from Apr 26, 2024

Conversation

benclifford
Copy link
Collaborator

The previous description of putting --config local tests into /sites/ and /integration/ does not reflect the reality of current Parsl development. cc @khk-globus who has put some thought into test organisation, but for now remove that advice.

Type of change

  • Update to human readable text: Documentation/error messages/comments

Copy link
Collaborator

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense; I don't actually know when we do run those site-specific tests. Is that something you do?

@benclifford
Copy link
Collaborator Author

benclifford commented Apr 26, 2024

parsl/tests/sites/ is "just another directory" of tests, including tests that are nothing to do with sites.

No one runs any site-specific tests ever - that cough principle is one of the drivers for moving to weekly auto-releases with explicit acceptance that there there is no human testing. See the work leading up to PR #2612 which made the first autorelease after no release at all for more than a year.

@benclifford benclifford merged commit 2697bb7 into master Apr 26, 2024
6 checks passed
@benclifford benclifford deleted the benc-doc-contribute-local-tests branch April 26, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants