Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the clang-tidy is a clang-based C++ “linter” tool. #295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add the clang-tidy is a clang-based C++ “linter” tool. #295

wants to merge 2 commits into from

Conversation

zusage
Copy link
Collaborator

@zusage zusage commented Aug 11, 2020

No description provided.

@zusage zusage force-pushed the clang-tidy branch 3 times, most recently from 545a98c to 2f55ea3 Compare September 14, 2020 09:55
bitmouse
bitmouse requested changes Sep 16, 2020
View reviewed changes
Copy link
Collaborator

@bitmouse bitmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaking is required, e.g.
src/common/FaceliftUtils.h:67:5: warning: overloading 'operator()' is disallowed [fuchsia-overloaded-operator]

It is 100% valid for us. We are not fuchsia project and we do not follow their standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitmouse bitmouse bitmouse requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zusage @bitmouse