Lib archive filename should be ascertained from Content-Disposition response header when such a header exists

[rsimoes]

Consider the following URL:

http://nodeload.github.com/yaml/libyaml/tar.gz/master

When Alien::Base::ModuleBuild downloads from this location, the file is saved as "master." Archive::Extract is then used on the file, but it's not able to determine the file type and croaks. To make Archive::Extract happy, the file name should be what is stipulated in the resource's Content-Disposition response header:

Content-Disposition:attachment; filename=libyaml-master.tar.gz

I may or may not get a chance to write up a patch tonight but figured I'd log the issue either way.

[jberger]

Thanks @rsimoes. I would happily accept a patch, otherwise I will leave this open to remind me.

I threaten every now and again to totally rewrite the ::HTTP class. It was a halfhearted effort. FTP (being lower hanging fruit and also how GSL is distributed) has been my focus.

[rsimoes]

For lack of adding a full HTTP test to Alien-Base, I manually tested with my Alien-LibYAML module using the the archive URL above.

[jberger]

I like the idea of using dependent libraries as unofficial tests of AB. It is the most "correct" path of testing that is really open to a library as abstract as AB is. I do this too, using Acme:: modules. Could you perhaps add a quick note to Alien::Base::Authoring.pod/EXAMPLES noting that the your YAML module serves as supplemental testing for HTTP delivery? After that I'm ok with merging.

And thanks!

[jberger]

Sorry for the long lapse on this. I'm trying to get back to AB maintenance as possible.

I have a new question about this patch. It does not fully implement the content-disposition spec specifically the filename="quotedstring" handling. I have been looking for a nice content-disposition parser on CPAN but haven't found one. Text::Balanced may be needed.

[mohawk2]

@rsimoes, do you have the opportunity to look into this? I'd like to get this closed off.

[plicease]

How about just change the regex to /filename=("?)(.+)\1/ or maybe /filename=("?)([^"]+)\1/. It doesn't exhaustively handle all corner cases, but does it need to?

[plicease]

@rsimoes I took your branch and made some tweaks and merged your changes. You can see #55 for details.