This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
content-disposition support #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aye - @zmughal, one other? |
|
Good that the regex is searchable with Have you tested this with Alien::LibYAML? Merge: Aye |
|
Alien::LibYAML works. |
|
Belatedly 👍 |
zmughal
added a commit
to zmughal/p5-Alien-Base
that referenced
this pull request
Sep 4, 2014
Conflicts: lib/Alien/Base/ModuleBuild/Repository/HTTP.pm This merges the changes between Perl5-Alien#24 and Perl5-Alien#55. See Perl5-Alien#56. Merging of [commit](https://github.com/plicease/Alien-Base/commit/a15536c804b9738ae3d45cd9a23ca427855c8927) by @plicease which adds header support for both LWP and HTTP::Tiny. This is needed for getting Content-Disposition information.
plicease
pushed a commit
that referenced
this pull request
Jul 17, 2017
Conflicts: lib/Alien/Base/ModuleBuild/Repository/HTTP.pm This merges the changes between #24 and #55. See #56. Merging of [commit](https://github.com/plicease/Alien-Base/commit/a15536c804b9738ae3d45cd9a23ca427855c8927) by @plicease which adds header support for both LWP and HTTP::Tiny. This is needed for getting Content-Disposition information.
plicease
pushed a commit
that referenced
this pull request
Jul 17, 2017
Conflicts: lib/Alien/Base/ModuleBuild/Repository/HTTP.pm This merges the changes between #24 and #55. See #56. Merging of [commit](https://github.com/plicease/Alien-Base/commit/a15536c804b9738ae3d45cd9a23ca427855c8927) by @plicease which adds header support for both LWP and HTTP::Tiny. This is needed for getting Content-Disposition information.
plicease
pushed a commit
that referenced
this pull request
Jul 17, 2017
Conflicts: lib/Alien/Base/ModuleBuild/Repository/HTTP.pm This merges the changes between #24 and #55. See #56. Merging of [commit](https://github.com/plicease/Alien-Base/commit/a15536c804b9738ae3d45cd9a23ca427855c8927) by @plicease which adds header support for both LWP and HTTP::Tiny. This is needed for getting Content-Disposition information.
plicease
pushed a commit
that referenced
this pull request
Jul 17, 2017
Conflicts: lib/Alien/Base/ModuleBuild/Repository/HTTP.pm This merges the changes between #24 and #55. See #56. Merging of [commit](https://github.com/plicease/Alien-Base/commit/a15536c804b9738ae3d45cd9a23ca427855c8927) by @plicease which adds header support for both LWP and HTTP::Tiny. This is needed for getting Content-Disposition information.
plicease
pushed a commit
that referenced
this pull request
Jul 17, 2017
Conflicts: lib/Alien/Base/ModuleBuild/Repository/HTTP.pm This merges the changes between #24 and #55. See #56. Merging of [commit](https://github.com/plicease/Alien-Base/commit/a15536c804b9738ae3d45cd9a23ca427855c8927) by @plicease which adds header support for both LWP and HTTP::Tiny. This is needed for getting Content-Disposition information.
plicease
added a commit
that referenced
this pull request
Jul 17, 2017
Alien-Base: Alien-Base: content-disposition support
plicease
pushed a commit
that referenced
this pull request
Jul 17, 2017
… plicease/lwp Alien-Base: Alien-Base: Conflicts: Alien-Base: lib/Alien/Base/ModuleBuild/Repository/HTTP.pm Alien-Base: Alien-Base: This merges the changes between #24 and #55. See #56. Alien-Base: Alien-Base: Merging of [commit](https://github.com/plicease/Alien-Base/commit/a15536c804b9738ae3d45cd9a23ca427855c8927) Alien-Base: by @plicease which adds header support for both LWP and HTTP::Tiny. This Alien-Base: is needed for getting Content-Disposition information.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my cleaned up version of #27 up for consideration.
The regexen that I have employed probably are not exhaustive, but they probably address most of the actual use cases out there in practice. Note that there is a conflict with #24, so maybe that PR could add some abstraction so that we don't have to special case every interaction with the response object/hash.
I vote for the inclusion of this PR: aye.