Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function JString #2

Closed
wants to merge 7 commits into from

Conversation

photodude
Copy link

JString has been depreciated use Joomla\String\StringHelper;

This PR updates the component to use the latest String package due to a B/C break in the Joomla CMS 3.5+ supporting one of the changes in PHP 7 resulting in new reserved keywords in the language.

Reference on this change requirement from the Joomla CMS
joomla/joomla-cms#6600

JString has been depreciated `use Joomla\String\StringHelper;` This PR updates the component to use the latest String package due to a B/C brake in the Joomla CMS supporting One of the changes in PHP 7 resulting in new reserved keywords in the language.
JString has been depreciated `use Joomla\String\StringHelper;`
JString has been depreciated `use Joomla\String\StringHelper;`
JString has been depreciated `use Joomla\String\StringHelper;`
JString has been depreciated `use Joomla\String\StringHelper;`
JString has been depreciated `use Joomla\String\StringHelper;`
JString has been depreciated `use Joomla\String\StringHelper;`
@PhocaCz
Copy link
Owner

PhocaCz commented Dec 14, 2015

Hi, thank you for this info.

Is it sure, this functions will stay in Joomla!?

libraries\vendor\joomla\string\src\StringHelper.php

Are there any info, what the vendor means?

Thank you very much.

Jan

Dne 14. 12. 2015 v 20:08 photodude napsal(a):

JString has been depreciated |use Joomla\String\StringHelper;|

This PR updates the component to use the latest String package due to
a B/C break in the Joomla CMS 3.5+ supporting one of the changes in
PHP 7 resulting in new reserved keywords in the language.

Reference on this change requirement from the Joomla CMS
joomla/joomla-cms#6600 joomla/joomla-cms#6600


    You can view, comment on, or merge this pull request online at:

#2

    Commit Summary


Reply to this email directly or view it on GitHub
#2.

@photodude
Copy link
Author

Vendor is just referencing "external libraries" to the Joomla CMS; since the string library is part of the Joomla Framework it's included as a "vendor library" rather than as a library of the CMS. (I know a bit confusing)

Long story short, it is a Joomla library and it will stay in the Joomla CMS as the official string helper library from now on. It's just a name and location change from the old Joomla platform JString → to the namespaced Joomla Framework String library → to the PHP7 compatible namespaced Joomla Framework StringHelper library

All the best,
Walt

@photodude photodude closed this Apr 2, 2017
@photodude photodude deleted the patch-2 branch April 2, 2017 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants