Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for complex numbers #325

Merged
merged 23 commits into from Jan 18, 2024
Merged

Add tests for complex numbers #325

merged 23 commits into from Jan 18, 2024

Conversation

hemalvarambhia
Copy link
Contributor

  • Added some missing tests

@hemalvarambhia
test: changed the test data to cos(pi/3) + i sin(pi/3).
d64a1bd
@hemalvarambhia
comment: added documentation that shows how to get the answer using D…
f96485e 
…e Moivre's theorem.
@hemalvarambhia
test: added another missing test.
f4d8a3c
@hemalvarambhia
refactor: made the test name shorter and hopefully more concise.
a04e512
@hemalvarambhia
fix: corrected the documentation.
eca5b1d
@hemalvarambhia
test: demonstrated that sending raiseToInteger: with floating point n…
abf6a61 
…umber raises an Error.
@hemalvarambhia
refactor: clarified the name of a method.
45b4d3c
@hemalvarambhia
refactor: ComplexNumber is a Whole Value and we can assert equality.
1a0b3ca
@hemalvarambhia
refactor: Inline Variable as it is not paying its rent.
fdae061
@hemalvarambhia
test: simplified the test a little.
ede673d
@hemalvarambhia
refactor: extracted computations to local variables.
baaa8a3
@hemalvarambhia
refactor: extracted writing complex numbers in polar coordinates to t…
ec19743 
…heir own tests.
@hemalvarambhia
refactor: corrected the name of the test.
2e882c9
@hemalvarambhia
refactor: renamed the test to make it clear we are writing complex nu…
94e6d49 
…mbers in cartesian coordinates.
@hemalvarambhia
refactor: clarified the names of some message arguments.
4ad4f60
@hemalvarambhia
Removed the comment, as the code is self-explanatory.
bca0a1f
@hemalvarambhia
refactor: Rename Variable where we clarify the name of a variable.
91af93f
@hemalvarambhia
chore: corrected the name of the comment.
9aaedf0
@hemalvarambhia
refactor/test: removed a comment, and added a missing test.
a9a955e
@hemalvarambhia
test: added another missing test.
b04f7c9
@hernanmd hernanmd merged commit 8555b80 into master Jan 18, 2024
8 checks passed
@hemalvarambhia
Copy link
Contributor Author

@hernanmd yes. I use it because it feels natural (I did a Theoretical Physics degree and z or w were used all the time) it makes it so much more DSL like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hernanmd hernanmd hernanmd approved these changes

@jordanmontt jordanmontt jordanmontt approved these changes

@SergeStinckwich SergeStinckwich Awaiting requested review from SergeStinckwich

@Ducasse Ducasse Awaiting requested review from Ducasse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hemalvarambhia @hernanmd @jordanmontt