fix: don't allocate BlockedsModsDialog

Fixes temporary memory leak! Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
PrismLauncher · Dec 5, 2022 · 0735986 · 0735986
1 parent 2fd7338
commit 0735986
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/launcher/modplatform/flame/FlameInstanceCreationTask.cpp b/launcher/modplatform/flame/FlameInstanceCreationTask.cpp
@@ -393,14 +393,14 @@ void FlameCreationTask::idResolverSucceeded(QEventLoop& loop)
     if (anyBlocked) {
         qWarning() << "Blocked mods found, displaying mod list";
 
-        auto message_dialog = new BlockedModsDialog(m_parent, tr("Blocked mods found"),
+        BlockedModsDialog message_dialog(m_parent, tr("Blocked mods found"),
                                                     tr("The following files are not available for download in third party launchers.<br/>"
                                                        "You will need to manually download them and add them to the instance."),
                                                     blocked_mods);
 
-        message_dialog->setModal(true);
+        message_dialog.setModal(true);
 
-        if (message_dialog->exec()) {
+        if (message_dialog.exec()) {
             qDebug() << "Post dialog blocked mods list: " << blocked_mods;
             copyBlockedMods(blocked_mods);
             setupDownloadJob(loop);

diff --git a/launcher/modplatform/modpacksch/FTBPackInstallTask.cpp b/launcher/modplatform/modpacksch/FTBPackInstallTask.cpp
@@ -210,12 +210,14 @@ void PackInstallTask::onResolveModsSucceeded()
     if (anyBlocked) {
         qDebug() << "Blocked files found, displaying file list";
 
-        auto message_dialog = new BlockedModsDialog(m_parent, tr("Blocked files found"),
+        BlockedModsDialog message_dialog(m_parent, tr("Blocked files found"),
                                                     tr("The following files are not available for download in third party launchers.<br/>"
                                                        "You will need to manually download them and add them to the instance."),
                                                     m_blocked_mods);
 
-        if (message_dialog->exec() == QDialog::Accepted) {
+        message_dialog.setModal(true);
+
+        if (message_dialog.exec() == QDialog::Accepted) {
             qDebug() << "Post dialog blocked mods list: " << m_blocked_mods;
             createInstance();
         } else {