Copy found blocked 3rd party mods to the new instance (ftb and curseforge) #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flowln
reviewed
Oct 26, 2022
flowln
reviewed
Oct 30, 2022
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Now that PrismLauncher#333 is merged and FS::copy works on non directory copyFile can be removed. Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
Rebased and removed |
FederAndInk
reviewed
Nov 1, 2022
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
flowln
approved these changes
Nov 2, 2022
1 task
1 task
Scrumplex
approved these changes
Nov 9, 2022
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
We all good now 👍 |
Scrumplex
approved these changes
Nov 11, 2022
|
for people with a custom download location, would be cool if you could just drag and drop or browse and insert the mods |
These are good suggestions and relatively easy to add, would you prefer them in this PR or a separate one? |
Probably another PR would be better, this one already has a good amount of changes, and will |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the user experience when dealing with mods blocked from 3rd party launchers.
Fixes #222
When the BlockedMods dialog is created it check the configured global mods folder and the users' downloads folder for the missing .jar names and if found verifies them by hash.
A filesystem watch is then established on both folders in case the user needs to download the missing mods.
The UI updates appropriately to indicate the blocked mods have been found.
Once the dialog has been accepted the mods are copied to the instance's mods folder.
Of note:
Code review is needed.