Add modpack update page in instance settings

[flowln]

Closes #180
Closes #170

TODO: I'm satisfied with the state of this for now, so I'll open it for review :p

• Modrinth modpack page
• Flame modpack page
• Fix icons with managed packs not from MR/CF (or probably hide them since we can't update them yet anyways)
• Make the changelog thing parse the content as markdown
• Add link to the modpack page in the mod provider
  • Modrinth URLs
  • Flame URLs not really sure how to do this. Maybe we should have another field in instance.cfg, or do another NetJob to get the thing (though it would be slow, blocking and really not super useful)

and probably some more stuff i forgot about :x

Status (as of 9cf53f8):

[CutestNekoAqua]

Button to update Modpack automatically too?

[CutestNekoAqua]

PS: What about a notification that there are updates for a modpack?

[flowln]

Button to update Modpack automatically too?

i don't feel great about automatically updating a modpack, since people should really backup their stuff before an update. But the idea is to have a button that allows for easy updating if the user wants to :)

PS: What about a notification that there are updates for a modpack?

maybe we could have something like that, but i guess you should make an issue about that, because it's unlikely i'll be able to do that in this single PR :p

[CutestNekoAqua]

Button to update Modpack automatically too?

i don't feel great about automatically updating a modpack, since people should really backup their stuff before an update. But the idea is to have a button that allows for easy updating if the user wants to :)
Yea, I did mean semi-automatic. You click the button and it does the update on its own. But you need to click it again for the next update.

PS: What about a notification that there are updates for a modpack?

maybe we could have something like that, but i guess you should make an issue about that, because it's unlikely i'll be able to do that in this single PR :p

Sure! I can even work on it as soon as you finished this PR myself :)

[Scrumplex]

Is this scheduled for 5.0?

[flowln]

Is this scheduled for 5.0?

if we are going to release 5.0 today, no :iea:

[HyperSoop]

Some of my own opinions on this:

• make this menu a button in "version" instead, I'd rather not have any of my instances individually cursed/blessed with having a whole separate menu on the sidebar for modpack information.
• make sure an instance's modpack status can be completely removed by the user through the launcher

[flowln]

make this menu a button in "version" instead, I'd rather not have any of my instances individually cursed/blessed with having a whole separate menu on the sidebar for modpack information.

i don't think only a button is enough for this. It doesn't provide useful information such as changelogs and other metadata, which can in fact be very important when updating. My original design was to make it a tab inside a 'Overview' page, instead of being in the sidebar, but that'll take more time to be done.

make sure an instance's modpack status can be completely removed by the user through the launcher

Maybe, but currently this status doesn't add any restriction on its own, so if you don't want to use an instance as a managed pack, you can just not use the tab :p

Perhaps it could be an option in the future (similar to adding such a status to an already existing instance).

[HyperSoop]

i don't think only a button is enough for this. It doesn't provide useful information such as changelogs and other metadata, which can in fact be very important when updating. My original design was to make it a tab inside a 'Overview' page, instead of being in the sidebar, but that'll take more time to be done.

Well, a button that opens the menu in a popup, that is.

[flowln]

Well, a button that opens the menu in a popup, that is.

why have it in a popup? it just seems unnecessary to me :/

[HyperSoop]

To not clutter the sidebar and to not have wast amounts of emptiness in the window in case the edit instance menu is stretched out to cover the whole screen

[flowln]

To not clutter the sidebar and to not have wast amounts of emptiness in the window in case the edit instance menu is stretched out to cover the whole screen

i think adding something here would be more clutter than having a page on the sidebar though

[HyperSoop]

we really should do something to this too though. we could swap the mod loader install section with the upper one, and move the folder shortcuts to the bottom.

Not to say there isn't clutter on the left.

[HyperSoop]

Maybe, but currently this status doesn't add any restriction on its own, so if you don't want to use an instance as a managed pack, you can just not use the tab :p

Perhaps it could be an option in the future (similar to adding such a status to an already existing instance).

I wouldn't like to have 50% of my instances permanently marked as modpacks just because they are based off SO. There also needs to be an option to completely disable new modpack instances from getting modpack metadata.

The modpack updater should be treated in the same way the mod updater is - it should not be in your eyes too much, it's just something that you use once in a while and then forget about it for a few days. If it's not so, it's bloat.

[HyperSoop]

Is it for sure that the "if a new instance of a modpack is created, annoyingly prompt the suer to update an existing one" will be removed with this PR? Again, I want to update my modpack instance when i want to update it, not when i create a new instance of it.

[flowln]

Dunno, some people seem to like it. It really depends on whether we can make the UX not be obnoxious for those that don't want it, but useful for those that do. Anyway, that'd not be done in this particular PR anyway, since it's not in the intended scope to change that.

[HyperSoop]

Can we make a toggle for this in the options? Like "Prompt to update modpack on instance creation"

[DioEgizio]

on curseforge packs, going to the curseforge tab, going back to version and then going back to curseforge causes a segmentation fault

[Scrumplex]

third approval

[ZekeZDev]

Looks great to me, everything seems functional and I cant find any glaring issues. I do think that we will need to consider future changes to make updates more accessible however as the page is I think it does its job well.

[RaptaG]

\ö/