feat: Building on MSVC

[TheLastRar]

This PR contains the work I've done getting PrismLauncher to build with MSVC
I'm willing to split this into smaller PRs if desired.

On a cache hit GitHub actions takes 2-3 minutes to build and 15 seconds to package, bringing it more inline with the other builds see run on my branch

You will need vc redist 2022/latest and, because of Qt5's OpenSSL dlls, vc redist 2010

The debug builds produced by the CI link to the release runtime, so Visual Studio is not required to run those builds
If you produce debug builds without -DCMAKE_MSVC_RUNTIME_LIBRARY="MultiThreadedDLL" then prism links to the debug runtime, giving better debugging capability. (Release builds without CMAKE_MSVC_RUNTIME_LIBRARY set still link with the release runtime)

zlib is bundled, but that only used if Launcher_FORCE_BUNDLED_LIBS is set or system zlib is not found by CMake.
ECM is also bundled, and is only used if the system ECM is not found.

I dropped the CMP0020 OLD policy to make my life a bit easier (and for Clang-cl), looking at git blame it was added to suppress cmake warnings,
I believe qtmain just has a calls our main() function anyway

The CI action I've added used the msbuild generators, as at the time I couldn't get Ninja to use ccache.
I did later have an idea on the issue and volunteered someone to test it (it worked), at that point, however, I had already switched to msbuild, but I should be able to switch back and keep ccache working if desired.

Fully supporting msbuild did require modifying the CMake file to support multi config generators, it still maintains support for single config generators like Ninja
An interesting experiment might be to see if the Ninja Multi-Config generator works as expected.

Code changes at the start of the series are fixing build issues with MSVC, code fixes at the end of the series is for Clang-cl
Clang-cl issues where spotted by getchoo in the discord, although I did not use their patch as-is

[TheLastRar]

I'll also take the opportunity to document what I've learned about cmake's install step with fixup_bundle on windows

If it's run in an environment that's been prepared by vcvars*.bat (such as the one you get when you run 'Native Tools Command Prompt for VS' or with the ilammy/msvc-dev-cmd action it actually runs pretty quick

MSYS2 however doesn't inherit all of the environment variables (namely additions to PATH), this can be corrected by setting path-type to inherit (desktop MSYS2 has a config file for this).
however this could lead to interference between MSYS2 and other tools installed on the system, so I never tested this in actions.

[DioEgizio]

also, don't forget to update the release workflow to add the new files!

[DioEgizio]

I'll also take the opportunity to document what I've learned about cmake's install step with fixup_bundle on windows

If it's run in an environment that's been prepared by vcvars*.bat (such as the one you get when you run 'Native Tools Command Prompt for VS' or with the ilammy/msvc-dev-cmd action it actually runs pretty quick

MSYS2 however doesn't inherit all of the environment variables (namely additions to PATH), this can be corrected by setting path-type to inherit (desktop MSYS2 has a config file for this). however this could lead to interference between MSYS2 and other tools installed on the system, so I never tested this in actions.

yeah, fixup_bundle/getprerequisites is weird in general, and it's also deprecated, but the alternative kinda sucks :p

[TheLastRar]

also, don't forget to update the release workflow to add the new files!

Dunno if I've modified the release workflow correctly, not sure how to test that

[TheLastRar]

Release workflow seems to work in a test branch

[txtsd]

Now rebase and you'll have the stack size fix.

EDIT: oh nvm. It's in here too.

[TheLastRar]

I should actually note that the legacy builds are on MSVC are Qt 5.15.2 instead of Qt 5.15.6 as that is the latest version that aqtinstall can grab, hopefully that isn't an issue. Legacy Mac is using the same version anyway.

Also seems like aqtinstall tripped up on the openssl libs, seems Qt updated it's OpenSSL libs today so maybe not everything aqt needs has gotten the memo, hopefully that resolves itself

[txtsd]

I should actually note that the legacy builds are on MSVC are Qt 5.15.2 instead of Qt 5.15.6 as that is the latest version that aqtinstall can grab, hopefully that isn't an issue. Legacy Mac is using the same version anyway.

Also seems like aqtinstall tripped up on the openssl libs, seems Qt updated it's OpenSSL libs today so maybe not everything aqt needs has gotten the memo, hopefully that resolves itself

We should probably pin all versions to known working ones 👀

[DioEgizio]

I should actually note that the legacy builds are on MSVC are Qt 5.15.2 instead of Qt 5.15.6 as that is the latest version that aqtinstall can grab, hopefully that isn't an issue. Legacy Mac is using the same version anyway.

it's not a big issue, and it's also the only version we can pick without compiling Qt from source :/

[DioEgizio]

I should actually note that the legacy builds are on MSVC are Qt 5.15.2 instead of Qt 5.15.6 as that is the latest version that aqtinstall can grab, hopefully that isn't an issue. Legacy Mac is using the same version anyway.
Also seems like aqtinstall tripped up on the openssl libs, seems Qt updated it's OpenSSL libs today so maybe not everything aqt needs has gotten the memo, hopefully that resolves itself

We should probably pin all versions to known working ones 👀

MSYS2 is rolling release, so we can't do that there

[Scrumplex]

Would be cool if we had Nix on Windows to pin dependencies

[DioEgizio]

we has

[Scrumplex]

Thanks a lot!