New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flatpak builds to the ci for testing #456
Conversation
I don't really like that we would be having duplicate code here and two places that would require updates |
I mean this is only on debug builds (yes I noticed it's building on release too, I have to fix later) |
Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
996031d
to
464b9eb
Compare
I think there's an alternative to maintaining two Flatpak manifests (it's a bit hacky, though):
- name: Checkout Flatpak manifest
uses: actions/checkout@v3
with:
repository: flathub/org.prismlauncher.PrismLauncher
- name: Install yq
uses: mikefarah/yq@v4.30.4
- name: Update Flatpak manifest to build using this repo
run: yq -i '(.modules[] | select(.sources[].url == "*/PrismLauncher/*")).sources = {"type": "dir", "path": ".."}' org.prismlauncher.PrismLauncher.yml
- name: Show modified manifest
run: cat org.prismlauncher.PrismLauncher.yml
# build flatpak... |
Very hacky and there can be breaking changes related to the build system between releases |
Yeah, it can get tricky... Perhaps another alternative is maintaining a single Flatpak manifest in-tree, like OBS Studio and Firefox both do for their apps:
I'm not sure if this requires a special process within Flathub, though. |
i think it's better to keep duplicated for now |
Who is going to keep this manifest up-to-date though? |
I guess we can update when it's needed, I don't think it'll need frequent updating anyways, and it can be useful for the actual stable flatpak to be able to have the manifest updated and see if there are any regressions |
closes #62