Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flatpak builds to the ci for testing #456

Merged
merged 1 commit into from Nov 18, 2022

Conversation

DioEgizio
Copy link
Member

closes #62

@DioEgizio DioEgizio added this to the 6.0 milestone Nov 15, 2022
@DioEgizio DioEgizio added enhancement New feature or request actions Issues and PRs related to GH actions and other CIs we might have packaging Issues and PRs related to packaging (CI builds or package managers) Linux Issues and PRs related to Linux specifically labels Nov 15, 2022
@Scrumplex
Copy link
Member

I don't really like that we would be having duplicate code here and two places that would require updates

@DioEgizio
Copy link
Member Author

I mean this is only on debug builds (yes I noticed it's building on release too, I have to fix later)
I don't think we can reuse the same yml everywhere

Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
@guihkx
Copy link
Contributor

guihkx commented Nov 15, 2022

I think there's an alternative to maintaining two Flatpak manifests (it's a bit hacky, though):

  1. Clone org.prismlauncher.PrismLauncher
  2. Use yq to update the required bits of the manifest, something like:
- name: Checkout Flatpak manifest
  uses: actions/checkout@v3
  with:
    repository: flathub/org.prismlauncher.PrismLauncher

- name: Install yq
  uses: mikefarah/yq@v4.30.4

- name: Update Flatpak manifest to build using this repo
  run: yq -i '(.modules[] | select(.sources[].url == "*/PrismLauncher/*")).sources = {"type": "dir", "path": ".."}' org.prismlauncher.PrismLauncher.yml

- name: Show modified manifest
  run: cat org.prismlauncher.PrismLauncher.yml

  # build flatpak...

@DioEgizio
Copy link
Member Author

Very hacky and there can be breaking changes related to the build system between releases

@guihkx
Copy link
Contributor

guihkx commented Nov 15, 2022

Yeah, it can get tricky... Perhaps another alternative is maintaining a single Flatpak manifest in-tree, like OBS Studio and Firefox both do for their apps:

I'm not sure if this requires a special process within Flathub, though.

@DioEgizio
Copy link
Member Author

i think it's better to keep duplicated for now

@Scrumplex
Copy link
Member

Who is going to keep this manifest up-to-date though?

@DioEgizio
Copy link
Member Author

I guess we can update when it's needed, I don't think it'll need frequent updating anyways, and it can be useful for the actual stable flatpak to be able to have the manifest updated and see if there are any regressions

@Scrumplex Scrumplex merged commit 347ae0a into PrismLauncher:develop Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Issues and PRs related to GH actions and other CIs we might have enhancement New feature or request Linux Issues and PRs related to Linux specifically packaging Issues and PRs related to packaging (CI builds or package managers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatpak artifacts for testing
4 participants