Fix serialization of components with custom metadata #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Prism has introduced a few extensions to the meta component version format, which were not exported as JSON in the launcher. This caused the `Customize` button on the version page to not write these new properties to the custom component file. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
changed the title
Scrumplex
changed the title
DioEgizio
approved these changes
Nov 16, 2022
flowln
approved these changes
Nov 16, 2022
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
flowln
approved these changes
Nov 16, 2022
TheKodeToad
added a commit
to TheKodeToad/PrismLauncher
that referenced
this pull request
Nov 17, 2022
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prism has introduced a few extensions to the meta component version
format, which were not exported as JSON in the launcher. This caused the
Customizebutton on the version page to not write these new propertiesto the custom component file.