fix(blockedmods): Track and use targetFolder for blocked files #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
flowln
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
thank you! :D
this indeed fixes the issue with the dialog. however, it also exacerbates the effects of #349 (like in the example of the issues, the datapack isn't actually a resource pack, and putting it in there is wrong). something to keep in mind for the future :^)
DioEgizio
approved these changes
Dec 9, 2022
Scrumplex
approved these changes
Dec 9, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #570
Simple fix, track and use the targetFolder from the file resolver.