Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new cat #99

Closed
wants to merge 9 commits into from
Closed

new cat #99

wants to merge 9 commits into from

Conversation

r58Playz
Copy link

Replace background cat with prismcat(made by me).
Still need to change the other 2.

PS: done online

Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
@r58Playz
Copy link
Author

Added all of the variants.

@r58Playz r58Playz marked this pull request as ready for review October 19, 2022 00:53
Copy link
Contributor

@AshtakaOOf AshtakaOOf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cat
Use this instead (made by me)

Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
@triphora
Copy link

We should use Rory instead.
https://rory.cat
@Chew Please give your approval to use Rory in Prism Launcher

@AshtakaOOf
Copy link
Contributor

AshtakaOOf commented Oct 19, 2022

We should use Rory instead. https://rory.cat @Chew Please give your approval to use Rory in Prism Launcher

He isn't a drawing :despair:

@Chew
Copy link

Chew commented Oct 19, 2022

This launcher is Rory approved. image

@triphora
Copy link

He isn't a drawing :despair:

@AshtakaOOf SHE is not a drawing, and I don't think it makes too much of a difference

@AshtakaOOf
Copy link
Contributor

@AshtakaOOf SHE is not a drawing, and I don't think it makes too much of a difference

¯_(ツ)_/¯

@cfazilleau
Copy link

As rory.cat even has a REST API, let's push it even further and get a random image from this API every time

@jn64
Copy link
Contributor

jn64 commented Oct 19, 2022

For special occasions

out min

#!/bin/bash

wget -q https://user-images.githubusercontent.com/66513643/196572431-827ef3bb-f08a-4783-8003-3450917af565.png -O 0.png

declare n=$(( 300 - (100 / 7 * 2 ) ))
for i in {0..5}; do
	convert "$i.png" -modulate 100,100,$n "$(( ++i )).png"
done

convert -delay 10 -loop 0 {0..6}.png out.gif
gifsicle -i -k 256 -O3 out.gif > out.min.gif

Copy link

@CutestNekoAqua CutestNekoAqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cat is good. but we should add more than one cat. maybe a fox too

@leumasme
Copy link
Contributor

I've always wondered why the cat looks so bad. Looks as if it had been upscaled and background removed automatically. The line width and shape is all over the place.
Is it maybe time to redraw the cat, or is there a special history behind this image?

@flowln flowln added enhancement New feature or request simple change labels Oct 19, 2022
@jschenke488
Copy link

He isn't a drawing :despair:

@AshtakaOOf SHE is not a drawing, and I don't think it makes too much of a difference

Get someone to draw Rory :)

@forkiesassds
Copy link
Contributor

... or is there a special history behind this image?

IIRC it was an inside joke from one of the MMC developers how the original image was on packaging for an ethernet cable, so they took a photo, traced it and colored it and thus background cat was born.

@Scrumplex
Copy link
Member

I do not feel comfortable replacing the cat. We might look into configurable backgrounds, though. We could offer some preset ones and allow users to provide their own.

@AshtakaOOf
Copy link
Contributor

Get someone to draw Rory :)

@Chew what do you think of this?
image
image

@Chew
Copy link

Chew commented Oct 22, 2022

They're beautiful 😍 @AshtakaOOf

@AshtakaOOf
Copy link
Contributor

https://rory.cat/id/11 Fanart

@Heath123
Copy link
Contributor

Can there be multiple cats with a way to cycle between them?

@jitterdev jitterdev mentioned this pull request Oct 23, 2022
1 task
@phit
Copy link
Contributor

phit commented Oct 24, 2022

Is it maybe time to redraw the cat, or is there a special history behind this image?

since the base cat was already explained, yes it was on a CAT cable box. I drew the christmas hat at some point in Paint because I thought it would be nice to have seasonal variants.

@txtsd
Copy link
Member

txtsd commented Oct 28, 2022

The Prism icon is not consistent across the newly added cats. And there are strange jagged borders between the colors.
Not saying we'll merge this, but nitpicking just in case anyways.

@AshtakaOOf
Copy link
Contributor

Should I do a PR with my Rory drawing? To replace Polycat?

Copy link

@Annabxlla Annabxlla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this but maybe also the option to have the original cat for some people who like the original better / some way to hold onto the past.

@AshtakaOOf
Copy link
Contributor

#372

@Scrumplex
Copy link
Member

Please integrate this with the system introduced by #372

@r58Playz
Copy link
Author

r58Playz commented Nov 2, 2022

#372

@r58Playz r58Playz closed this Nov 2, 2022
@r58Playz r58Playz deleted the patch-1 branch November 2, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet