Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add save and load for pythainlp.classify.param_free.GzipModel #908

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

wannaphong
Copy link
Member

Add save and load model for pythainlp.classify.param_free.GzipModel

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@pep8speaks
Copy link

pep8speaks commented Apr 26, 2024

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 20:60: E252 missing whitespace around parameter equals
Line 20:61: E252 missing whitespace around parameter equals
Line 20:82: E252 missing whitespace around parameter equals
Line 20:83: E252 missing whitespace around parameter equals
Line 21:22: E225 missing whitespace around operator
Line 21:22: E711 comparison to None should be 'if cond is not None:'
Line 84:27: E231 missing whitespace after ':'
Line 90:28: E222 multiple spaces after operator

Comment last updated at 2024-05-06 17:17:30 UTC

@wannaphong wannaphong changed the title [WIP] Add save and load [WIP] Add save and load for pythainlp.classify.param_free.GzipModel Apr 26, 2024
@coveralls
Copy link

coveralls commented Apr 26, 2024

Coverage Status

coverage: 79.04% (-0.02%) from 79.063%
when pulling b09e8bd on add-save-load-param_free
into 13a6c7c on dev.

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants