Fix empty string ('') added (in some cases) when using word_tokenize with join_broken_num=True #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix empty string bug PyThaiNLP#911
fix space before :
|
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix empty string bug
What does this changes
pythainlp/tokenize/_utils.py : add the statement
if connected_token :to check before appendingconnected_tokentotokens_joinedWhat was wrong
#911
How this fixes it
tokens_joinedwon't be appended by empty string anymoreYour checklist for this pull request
馃毃Please review the guidelines for contributing to this repository.