Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiple gridTypes for SquareGrid #4105

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

goblin-3
Copy link

@goblin-3 goblin-3 commented Jun 1, 2023

Requirements for Contributing a Bug Fix or Enhancement

Identify the Bug or Feature request

Resolves #3840

Description of the Change

I added an extra item to the adjustGridControlPanelView.form to select a grid type. using a getGridtype in the squareGrid.draw the correct grid type should be displayed

Possible Drawbacks

given the extra steps the draw function has to do there may be a slight performance hit

Documentation Notes

added additional grid type support for square grid

Release Notes

added additional grid type support for square grid


This change is Reviewable

@cwisniew cwisniew changed the title added multiple gridTypes for SquareGrid Added multiple gridTypes for SquareGrid Jun 8, 2023
@cwisniew
Copy link
Member

cwisniew commented Jun 8, 2023

@goblin-3 the formatting check has failed, could you please run
.\gradlew spotlessApply (for windows, or)
./gradlew spotlessApply (for linux, mac)

To fix the formatting locally, then commit and push your changes to same branch which will automatically get picked up by this PR

Thanks

@cwisniew cwisniew added the feature Adding functionality that adds value label Jun 8, 2023
@bubblobill
Copy link
Collaborator

Does not resolve #3840,
Does contribute towards resolution, but as mentioned in #3840, the solution needs to be one that can be applied to all existing Grid Types, i.e. Square, Hex_H, Hex_V, and Iso (should probably also leave the door open for implementation of future grid types, Hex_Iso, Triangle and Tri_Iso).
Although I would rather a LineStyle exist in its own enum, we do need the feature of being able to define whiche style to apply which this implements.
As it is, any changes this makes will not propogate to clients. Player clients cannot access the adjustment tool so the view will only change for the GM.
To fully resolve the issue we will need to build on this; enabling clients to select the line style and incorporate any rendering preferences into data transfer.

@bubblobill
Copy link
Collaborator

If this doesn't get up I will definitely be stealing bits of it for my future work on Grids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Additional options for displaying grid lines
3 participants