remove spurious parenthesis [gcc8 warning] (closes #841)

RcppCore · Mar 31, 2018 · c91d78a · c91d78a · jerryjcgf · May 9, 2018
1 parent 78408fa
commit c91d78a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,10 @@
+2018-03-31  Dirk Eddelbuettel  <edd@debian.org>
+
+        * inst/include/Rcpp/sprintf.h (Rcpp): Remove parens [gcc8 warning]
+
+        * vignettes/Rcpp-attributes.Rmd: Update link to JSS intro vignette
+        * vignettes/Rcpp-modules.Rmd: Idem
+
 2018-03-21  Dirk Eddelbuettel  <edd@debian.org>
 
         * DESCRIPTION (Version, Date): Roll minor version

diff --git a/inst/NEWS.Rd b/inst/NEWS.Rd
@@ -10,6 +10,11 @@
       \item The random number \code{Generator} class no longer inhreits from
       \code{RNGScope} (Kevin in \ghpr{837} fixing \ghit{836}).
     }
+    \item Changes in Rcpp Documentation:
+    \itemize{
+      \item Two internal links to the introduction published in JSS have been
+      updated to the changed filename given the newer TAS introduction.
+    }
   }
 }
 

diff --git a/inst/include/Rcpp/sprintf.h b/inst/include/Rcpp/sprintf.h
@@ -2,7 +2,7 @@
 //
 // sprintf.h: Rcpp R/C++ interface class library -- string formatting
 //
-// Copyright (C) 2010 - 2011 Dirk Eddelbuettel and Romain Francois
+// Copyright (C) 2010 - 2018  Dirk Eddelbuettel and Romain Francois
 //
 // This file is part of Rcpp.
 //
@@ -22,14 +22,14 @@
 #include <cstdio>
 #include <cstdarg>
 
-namespace Rcpp{
+namespace Rcpp {
 
 template <int MAX_SIZE>
 std::string sprintf( const char *format, ...) {
     static char buffer[MAX_SIZE];
-    va_list(ap);
+    va_list ap;
     va_start(ap, format);
-    vsnprintf( buffer, MAX_SIZE, format, ap);
+    vsnprintf(buffer, MAX_SIZE, format, ap);
     va_end(ap);
     return buffer ;
 }