MOD-6534: Missing values indexing - Add support to indexing pipeline #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
raz-mon
reviewed
May 20, 2024
src/redisearch_api.c
Outdated
| @@ -44,6 +44,7 @@ RefManager* RediSearch_CreateIndex(const char* name, const RSIndexOptions* optio | |||
| IndexSpec* spec = NewIndexSpec(name); | |||
| StrongRef ref = StrongRef_New(spec, (RefManager_Free)IndexSpec_Free); | |||
| IndexSpec_MakeKeyless(spec); | |||
| spec->missingFieldDict = dictCreate(&dictTypeHeapStrings, NULL); | |||
There was a problem hiding this comment.
Add to IndexSpec_MakeKeyless()
src/fork_gc.c
Outdated
| RedisSearchCtx_UnlockSpec(sctx); | ||
| StrongRef_Release(spec_ref); | ||
| } | ||
|
|
raz-mon
merged commit 5aa4ede
into
feature_missing_values_indexing
6 of 7 checks passed
raz-mon
pushed a commit
that referenced
this pull request
May 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
* MOD-6533, MOD-6581: Support MISSING indexing syntax (#4635) * Parsing support for missing values querying (#4641) * MOD-6534: Missing values indexing - Add support to indexing pipeline (#4638) * Create missing index iterator for missing QueryNode (#4650) * Patching indexing and querying pipelines together * WIP: Adding testsMissing() * Fix intersect problem (#4658) * WIP: testMissing() * WIP Add tests * Add tests * Test SORTABLE case * Test Explain * Support indexing missing values for geo, geoshape, numeric (TODO: Vector) * Minor fixes * Support ISMISSING in parser/v3 * Fix parseGeometryField() * Support indexing missing values for VECTOR * Test ismissing vector field * Reorganize tests and test WITHSUFFIXTRIE case * Test ft.aggregate and two ismissing fields * JSON tests fail in cluster * Fix IndexSpec_FreeUnlinkedData() * IndexSpec_FreeUnlinkedData() dont delete entry * Fix test * Remove errors thrown for queries of non-existing fields * Review * Optimize missing values indexing pipeline * Free missingFieldDict using valDestructor callback * test_missing: Add notes to bugs unrelated to ISMISSING * Fix JSON test * Fix increment * Fix missingFieldDictType * refactor ismissing to indexmissing in index creation * Small touchup * Fix commands.json * code review fixes * Fix info test * Check redis-py version in test_info_modules.py * Check redis-py version for amazonlinux:2 --------- Co-authored-by: Raz Monsonego <74051729+raz-mon@users.noreply.github.com> Co-authored-by: raz-mon <razmonsonego2@gmail.com> Co-authored-by: Omer Shadmi <omer.shadmi@redis.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
* MOD-6533, MOD-6581: Support MISSING indexing syntax (#4635) * Parsing support for missing values querying (#4641) * MOD-6534: Missing values indexing - Add support to indexing pipeline (#4638) * Create missing index iterator for missing QueryNode (#4650) * Patching indexing and querying pipelines together * WIP: Adding testsMissing() * Fix intersect problem (#4658) * WIP: testMissing() * WIP Add tests * Add tests * Test SORTABLE case * Test Explain * Support indexing missing values for geo, geoshape, numeric (TODO: Vector) * Minor fixes * Support ISMISSING in parser/v3 * Fix parseGeometryField() * Support indexing missing values for VECTOR * Test ismissing vector field * Reorganize tests and test WITHSUFFIXTRIE case * Test ft.aggregate and two ismissing fields * JSON tests fail in cluster * Fix IndexSpec_FreeUnlinkedData() * IndexSpec_FreeUnlinkedData() dont delete entry * Fix test * Remove errors thrown for queries of non-existing fields * Review * Optimize missing values indexing pipeline * Free missingFieldDict using valDestructor callback * test_missing: Add notes to bugs unrelated to ISMISSING * Fix JSON test * Fix increment * Fix missingFieldDictType * refactor ismissing to indexmissing in index creation * Small touchup * Fix commands.json * code review fixes * Fix info test * Check redis-py version in test_info_modules.py * Check redis-py version for amazonlinux:2 --------- Co-authored-by: Raz Monsonego <74051729+raz-mon@users.noreply.github.com> Co-authored-by: raz-mon <razmonsonego2@gmail.com> Co-authored-by: Omer Shadmi <omer.shadmi@redis.com> (cherry picked from commit 924f700)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
MOD-6532: Support indexing of missing values (#4682) * MOD-6533, MOD-6581: Support MISSING indexing syntax (#4635) * Parsing support for missing values querying (#4641) * MOD-6534: Missing values indexing - Add support to indexing pipeline (#4638) * Create missing index iterator for missing QueryNode (#4650) * Patching indexing and querying pipelines together * WIP: Adding testsMissing() * Fix intersect problem (#4658) * WIP: testMissing() * WIP Add tests * Add tests * Test SORTABLE case * Test Explain * Support indexing missing values for geo, geoshape, numeric (TODO: Vector) * Minor fixes * Support ISMISSING in parser/v3 * Fix parseGeometryField() * Support indexing missing values for VECTOR * Test ismissing vector field * Reorganize tests and test WITHSUFFIXTRIE case * Test ft.aggregate and two ismissing fields * JSON tests fail in cluster * Fix IndexSpec_FreeUnlinkedData() * IndexSpec_FreeUnlinkedData() dont delete entry * Fix test * Remove errors thrown for queries of non-existing fields * Review * Optimize missing values indexing pipeline * Free missingFieldDict using valDestructor callback * test_missing: Add notes to bugs unrelated to ISMISSING * Fix JSON test * Fix increment * Fix missingFieldDictType * refactor ismissing to indexmissing in index creation * Small touchup * Fix commands.json * code review fixes * Fix info test * Check redis-py version in test_info_modules.py * Check redis-py version for amazonlinux:2 --------- Co-authored-by: Raz Monsonego <74051729+raz-mon@users.noreply.github.com> Co-authored-by: raz-mon <razmonsonego2@gmail.com> Co-authored-by: Omer Shadmi <omer.shadmi@redis.com> (cherry picked from commit 924f700) Co-authored-by: nafraf <nafraf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of what the PR is solving, including:
Which issues this PR fixes
Main objects this PR modified
Mark if applicable