Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOD-7122: Fix numeric operator with signed param #4649

Merged
merged 10 commits into from
Jun 10, 2024

Conversation

nafraf
Copy link
Collaborator

@nafraf nafraf commented May 17, 2024

Description

  1. Current state: signed params are not evaluated correctly when used with numeric operators:
127.0.0.1:6379> FT.explaincli idx '@n>-$p' dialect 5 PARAMS 2 p 100
1) NUMERIC {100.000000 < @n <= inf}
  1. Change:
    The function int ParseDouble(const char *arg, double *d, int sign) was modified to receive and handle the parameter's sign.

Which issues this PR fixes

  1. MOD-7122

Main objects this PR modified

  1. ...
  2. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@nafraf nafraf marked this pull request as ready for review May 18, 2024 05:07
Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (29b2e46) to head (e3bcdb2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4649      +/-   ##
==========================================
- Coverage   86.21%   86.21%   -0.01%     
==========================================
  Files         190      190              
  Lines       35034    35036       +2     
==========================================
+ Hits        30205    30206       +1     
- Misses       4829     4830       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nafraf nafraf changed the title Fix numeric operator with signed param MOD-7122: Fix numeric operator with signed param May 21, 2024
@nafraf nafraf requested a review from oshadmi May 27, 2024 23:14
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎇

@nafraf nafraf added this pull request to the merge queue Jun 9, 2024
Merged via the queue into master with commit d6c9df4 Jun 10, 2024
10 checks passed
@nafraf nafraf deleted the nafraf_fix-num-operator-signed-param branch June 10, 2024 00:46
@nafraf
Copy link
Collaborator Author

nafraf commented Jun 10, 2024

/backport

Copy link

Successfully created backport PR for 2.10:

github-actions bot pushed a commit that referenced this pull request Jun 10, 2024
* Fix numeric operator with signed param

* Fix test

(cherry picked from commit d6c9df4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants