Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften Profile inheritence rules #262

Merged
merged 27 commits into from
May 23, 2024
Merged

Soften Profile inheritence rules #262

merged 27 commits into from
May 23, 2024

Conversation

stain
Copy link
Contributor

@stain stain commented May 23, 2023

In some cases, such as Workflow Run Crate there are multiple profiles that are related with inheritance.

There are also less strict inheritance profiles such as https://trefx.uk/trusted-wfrun-crate/0.3/

This section now makes it softer how to list multiple profiles, they are suggestions rather than enforcing any hierarchy.

@stain stain requested review from ptsefton and simleo May 23, 2023 01:43
docs/1.2-DRAFT/profiles.md Outdated Show resolved Hide resolved
docs/1.2-DRAFT/profiles.md Show resolved Hide resolved
docs/1.2-DRAFT/profiles.md Outdated Show resolved Hide resolved
docs/1.2-DRAFT/profiles.md Outdated Show resolved Hide resolved
@stain stain added this to the RO-Crate 1.2 milestone May 25, 2023
@stain stain added this to Under discussion/review in RO-Crate specifications via automation May 25, 2023
@ptsefton
Copy link
Contributor

Didn't we decide to remove all this from 1.2? @stain

@ptsefton
Copy link
Contributor

This needs to be moved to a different document, right?

@stain
Copy link
Contributor Author

stain commented Feb 8, 2024

Remove inheritance, at best "referenced/suggested" profiles.

@stain
Copy link
Contributor Author

stain commented Apr 11, 2024

Decision 2024-04-11: Not do formal inheritance system at RO-Crate level yet before we have tried out how it works with actual implementations (e.g. SHACL, Crate-O modes) -- then facilitate them.

@stain
Copy link
Contributor Author

stain commented Apr 26, 2024

I have finally managed to tidy up the profile section.

Changes:

  • Merged to latest master (but pending How to reference and retrieve another RO-Crate #296 with retrieval section moved out from here)
  • Use only rdfs:Class and rdf:Property, documented as Schema.org style schemas
  • Inheritance across profiles now only "Multiple Profiles" as suggestions of conformance only
  • Renamed section "Shared contextual entities from a Profile Crate"
  • Examples expanded following @simleo's suggestion

@stain stain requested a review from simleo April 26, 2024 00:25
@stain
Copy link
Contributor Author

stain commented Apr 26, 2024

Suggestion in call 2024-04-25 @CaroleGoble was to also look at Delegation pattern:

In a sense we use delegation pattern in https://trefx.uk/5s-crate/0.4/#referencing-a-workflow-crate as instead of subclassing Workflow RO-Crate, it references the Workflow RO-Crate by URL -- one crate to another. I've documented this pattern in #296.

This would make the resulting 5s-crate as Workflow Run Crate not conform to any strict inheritance rules, as it would not have the usual ComputationalWorkflow etc. and so should not itself declare conformsTo the Workflow RO-Crate (which we would have to then make Workflow RO-Crate indirection also be a workflow language!).

Note a side issue: at the moment that 5s-crate is in that case purposefully ignoring the MUST of conformsTo requirements -- we can argue over that separately!

@stain stain changed the title Make profile inheritance explicit Soften Profile inheritence rules May 9, 2024
@stain
Copy link
Contributor Author

stain commented May 20, 2024

@simleo Good to go..?

@stain stain requested a review from simleo May 20, 2024 19:12
@simleo
Copy link
Contributor

simleo commented May 21, 2024

@simleo Good to go..?

AFAICT, yes

@stain stain merged commit 7ae6169 into master May 23, 2024
RO-Crate specifications automation moved this from Under discussion/review to Done May 23, 2024
@stain stain deleted the profile-inheritance branch May 23, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants