Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intrinsic width is bogus #121

Closed
zcorpan opened this issue Feb 27, 2014 · 0 comments · Fixed by #142
Closed

Intrinsic width is bogus #121

zcorpan opened this issue Feb 27, 2014 · 0 comments · Fixed by #142

Comments

@zcorpan
Copy link

zcorpan commented Feb 27, 2014

"The intrinsic width of el is the result of finding the effective size from source list."
http://picture.responsiveimages.org/#select-an-image-source

I just realized that this is bogus. For starters, if the sizes attribute is absent, the intrinsic width will be set to 300px every time the UA decides to start a new image load. Even if the sizes attribute is present, the values in it are supposed to be approximate, not appropriate for setting the intrinsic width of the image.

If anything we should use the width descriptor and divide by the density. Then calculate the intrinsic height from the aspectratio attribute (#85). If we don't know both the width and height, maybe we shouldn't update either of them when selecting an image source (since it would cause the old image to be stretched).

zcorpan added a commit to zcorpan/picture-element that referenced this issue Apr 9, 2014
…e intrinsic resolution here; we return the density and the HTML spec handles the resolution with 'current pixel density'. Fixes ResponsiveImagesCG#121 Fixes ResponsiveImagesCG#107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant