Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where to set intrinsic width/resolution #107

Closed
zcorpan opened this issue Feb 19, 2014 · 0 comments · Fixed by #142
Closed

Where to set intrinsic width/resolution #107

zcorpan opened this issue Feb 19, 2014 · 0 comments · Fixed by #142

Comments

@zcorpan
Copy link

zcorpan commented Feb 19, 2014

"The intrinsic width of el is the result of finding the effective size from source list. The intrinsic resolution of el is the density associated with selected source."

http://picture.responsiveimages.org/#select-an-image-source

This seems like a layering violation to me. Considering #91 I think this algorithm should only select a URL and return it (along with the density, width, height), not set things like intrinsic width on the element directly.
@eeeps eeeps mentioned this issue Feb 28, 2014
Open
zcorpan added a commit to zcorpan/picture-element that referenced this issue Apr 9, 2014
@zcorpan
Don't set intrinsic width from sizes since that's bogus. Don't set th…
e9c06ea 
…e intrinsic resolution here; we return the density and the HTML spec handles the resolution with 'current pixel density'. Fixes ResponsiveImagesCG#121 Fixes ResponsiveImagesCG#107
@zcorpan zcorpan mentioned this issue Apr 9, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't set intrinsic width from sizes since that's bogus. Don't set the i... zcorpan/picture-element
1 participant
@zcorpan