Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Regression in prune by user, and update lastMessage #11646

Merged
merged 3 commits into from Aug 7, 2018

Conversation

vynmera
Copy link
Contributor

@vynmera vynmera commented Aug 1, 2018

Closes #11607
Closes #11648

811b832 forgot to remove all usages of Session, causing the users field to not be used.

Furthermore, I forgot to update lastMessage when pruning channels, so if the prune includes the latest message the database will hold wrong info.

@vynmera vynmera changed the title [FIX] Regression in prune by user [FIX] Regression in prune by user, and update lastMessage Aug 1, 2018
@sampaiodiego sampaiodiego added this to In progress in August/2018 via automation Aug 2, 2018
@sampaiodiego sampaiodiego added this to the 0.69.0 milestone Aug 2, 2018
@sampaiodiego sampaiodiego moved this from In progress to Review/QA in August/2018 Aug 2, 2018
August/2018 automation moved this from Review/QA to Ready to merge Aug 7, 2018
@ggazzo ggazzo merged commit fb21713 into RocketChat:develop Aug 7, 2018
August/2018 automation moved this from Ready to merge to Done Aug 7, 2018
@sampaiodiego sampaiodiego modified the milestones: 0.69.0, 0.68.4 Aug 9, 2018
sampaiodiego pushed a commit that referenced this pull request Aug 10, 2018
* Fix regression

* Also update lastMessage

* code style fix
@sampaiodiego sampaiodiego mentioned this pull request Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
August/2018
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants