fix: PDFs uploaded by "PDF transcript" feature were returnig 403 when attempting to download #32329
+136
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 80a4678 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32329 +/- ##
===========================================
- Coverage 55.88% 55.86% -0.03%
===========================================
Files 2432 2432
Lines 53478 53479 +1
Branches 10992 10993 +1
===========================================
- Hits 29888 29874 -14
- Misses 20955 20965 +10
- Partials 2635 2640 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
debdutdeb
reviewed
May 1, 2024
MarcosSpessatto
requested changes
May 10, 2024
MarcosSpessatto
requested changes
May 17, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
MarcosSpessatto
previously approved these changes
May 20, 2024
MarcosSpessatto
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/CORE-399
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Added a new setting
Restrict files access to users who can access roomthat controls file visibility. This new setting allows users that "can access a room" to also download the files that are there. This is specially important for users with livechat manager or monitor roles, or agents that have special permissions to view closed rooms, since this allows them to download files on the conversation even after the conversation is closed.New setting is disabled by default and it is mutually exclusive with the setting
Restrict file access to room memberssince this allows more types of users to download files.