New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Improve permissions check on cloud endpoints #32331
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32331 +/- ##
=================================================
- Coverage 55.56% 55.55% -0.01%
=================================================
Files 2333 2332 -1
Lines 51578 51547 -31
Branches 10526 10520 -6
=================================================
- Hits 28657 28638 -19
+ Misses 20403 20392 -11
+ Partials 2518 2517 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll skip integration tests since we don't support mocking cloud requests yet, it should be addressed in the future.
Proposed changes (including videos or screenshots)
cloud
endpoints by using thepermissionsRequired
property.Issue(s)
CORE-338
Steps to test or reproduce
Further comments
The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.
End-to-end tests not added in this one since we don't have any yet.